Extra test scenarios #208
Extra test scenarios #208
Conversation
| * | ||
| * @phpstan-param string $foo | ||
| * @psalm-param string $foo | ||
| * @phpstan-return true |
There was a problem hiding this comment.
Do you want to handle these?
| @@ -28,3 +29,5 @@ | |||
| extract($bar); | |||
|
|
|||
| compact('foo', 'bar'); | |||
|
|
|||
| array_map('is_null', ['1', '2', null]); // forbidden function will not be detected | |||
There was a problem hiding this comment.
FYI codesniffer can not detect these.. is this fine?
| class FooError extends Error | ||
| { | ||
| } | ||
|
|
There was a problem hiding this comment.
This is superfluous but not reported.. i guess there is no existing rule for this
| return true; | ||
| } | ||
|
|
||
| // Return true here in case $bar is bar |
There was a problem hiding this comment.
| for ( | ||
| $i = 0; $i < 10; | ||
| $i++ | ||
| ); |
There was a problem hiding this comment.
| @@ -23,6 +23,7 @@ class Example implements \IteratorAggregate | |||
| { | |||
| private const VERSION = \PHP_VERSION - (PHP_MINOR_VERSION * 100) - PHP_PATCH_VERSION; | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
FYI currently there is no sniff included that fixes the extra lines inside a class.. it does fix the extra lines between functions but it does not look inside the whole class.
There was a problem hiding this comment.
SlevomatCodingStandard.Classes.ClassMemberSpacing
There was a problem hiding this comment.
Great.. will create a new PR with that..
There was a problem hiding this comment.
There are also:
MethodSpacingPropertySpacingConstantSpacing
I tried to improve the test case scenarios that you have.
I found a couple of bugs also.. Will report them upstream..
In the meantime you might be interested in some discussion about a couple of those and how to resolve them.